Peer at link-local addresses: fe80::1%eth0

A peer's endpoint may be a link-local IPv6 address with the interface it
is on. Such a peer is the address and the interface together, wherever
peers are told apart: admission, collisions, hold-downs, the refusal log,
the status page. The interface is looked up by name each time it is
needed, so one that appears later or is made anew is found.

Our routes go out with our link-local address in both places of
MP_REACH_NLRI's next hop, as FRR sends its own. A peer's link-local next
hop is taken alone, twice, or after "::" (BIRD), and resolved in the
kernel on the interface of the session rather than by looking fe80::/64
up, which every interface has.

The lab has a new phase, linklocal: sessions with FRR (by interface, with
radvd beside the daemon) and BIRD over a LAN with link-local addresses
only, both families, pings across, the interface down and up.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

crates/server/src/session.rs

@@ -6,7 +6,7 @@
 //! the registry to enumerate live sessions and queue outbound messages.
 
 use std::collections::HashMap;
-use std::net::{IpAddr, SocketAddr};
+use std::net::SocketAddr;
 use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
 use std::sync::{Arc, RwLock};
 use std::time::{Duration, SystemTime};
@@ -19,6 +19,7 @@ use bgp_primitives::ip_prefix::Nlri;
 use bgp_rib::table::PeerIndex;
 use tokio::sync::{broadcast, mpsc};
 
+use crate::address::{Endpoint, PeerAddress, socket_text};
 use crate::collision::Direction;
 use crate::family::FamilySet;
 use crate::fsm::Negotiated;
@@ -38,7 +39,7 @@ pub struct PeerId {
 
 impl std::fmt::Display for PeerId {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        write!(f, "{}(AS{})", self.addr, self.asn)
+        write!(f, "{}(AS{})", socket_text(self.addr), self.asn)
     }
 }
 
@@ -60,7 +61,7 @@ pub enum DialState {
 #[derive(Debug, Clone)]
 pub struct ConfiguredPeer {
     pub name: String,
-    pub endpoint: SocketAddr,
+    pub endpoint: Endpoint,
     pub remote_asn: u32,
     /// What the peer is to us, if that was said.
     pub role: Option<PeerRole>,
@@ -289,13 +290,13 @@ impl SessionRegistry {
         self.dial_states.writing().insert(name.to_string(), state);
     }
 
-    /// An established session with this remote IP and ASN, regardless of
-    /// which side opened the TCP connection.
-    pub fn find(&self, ip: IpAddr, asn: u32) -> Option<SessionHandle> {
+    /// An established session with the peer at this address and with this
+    /// ASN, regardless of which side opened the TCP connection.
+    pub fn find(&self, address: PeerAddress, asn: u32) -> Option<SessionHandle> {
         self.inner
             .reading()
             .values()
-            .find(|h| h.peer.addr.ip() == ip && h.peer.asn == asn)
+            .find(|h| PeerAddress::from(h.peer.addr) == address && h.peer.asn == asn)
             .cloned()
     }